Did PRESIDENT Trump share critical information with the Russians?
That is one reason that intelligence is gathered from both open sources and by covert means so that one can have REAL data upon which to base conversations and negotiations with both allies and adversaries. That is the JOB of being PRESIDENT.
Both the National Security Advisor and the Secretary of State have stated that the content of Trump's conversation with the Russians was WHOLLY APPROPRIATE TO THE CONVERSATION. And that NO, he did not compromise any intelligence sources or methods, and further that he did not share anything that was not available from "open source" reporting.